Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Implement RFC-2299 for list_with #2323

Merged
merged 5 commits into from
May 25, 2023
Merged

refactor(core): Implement RFC-2299 for list_with #2323

merged 5 commits into from
May 25, 2023

Conversation

infdahai
Copy link
Contributor

No description provided.

@infdahai
refactor(core): Implement RFC-2299 for list_with
51e1951 
Signed-off-by: clundro <infdahai@outlook.com>
@infdahai
add brace
be9c184 
Signed-off-by: clundro <infdahai@outlook.com>
@infdahai
Copy link
Contributor Author

https://github.com/apache/incubator-opendal/blob/9bdd422d0e3a383f6f76593e6503b82d9b26db7c/core/src/types/operator/operator.rs#L1396-L1416

I don't edit the scan function.

@Xuanwo
Copy link
Member

Xuanwo commented May 25, 2023

I don't edit the scan function.

I think we can change this into calling list_with()?

@infdahai
change scan func
e277f6f 
Signed-off-by: clundro <infdahai@outlook.com>
@infdahai
add oplist bound
925b93b 
Signed-off-by: clundro <infdahai@outlook.com>
@Xuanwo
Fix build
0d1b6a0 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo mentioned this pull request May 25, 2023
Closed
11 tasks
suyanhanx
suyanhanx approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 19241c7 into apache:main May 25, 2023
@infdahai infdahai deleted the sup_list branch May 25, 2023 17:15
@Xuanwo Xuanwo mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@infdahai @Xuanwo @suyanhanx